RE:[sap-dev] Field-symbols question
Posted by
Admin at
|
Share this post:
|
|
0 Comments
 | Posted by horacio zapettini on May 13 at 3:05 PM |  Mark as helpful |
How about changing that itab to hashed table?? Modify's are faster.
De: sapwes via sap-dev [mailto:sap-dev@Groups.ITtoolbox.com]
Enviado el: Jueves, 13 de Mayo de 2010 01:00 p.m.
Para: Horacio Zapettini
Asunto: RE:[sap-dev] Field-symbols question
Posted by sapwes (Jack)
on May 13 at 12:03 PM Mark as helpful
All:
Just checked the code looks like I got it now - the dereferencing is gone (YAY!!). Part of the problem is the developer's unfamiliarity with field symbols.
HZ:
No the perf issue is in the loop.
The original select of of 2mil rows took 22 secs in our QA system. But the loop was taking 13 minutes just to set a eligible flag on the internal table.
We rejiggered the where clause in the select to reduce the rows to 500K, the select is now taking 45 seconds (probaly some indexing issues to resolve). And as well with the field symbol info almost correctly in place, the main loop is now running in 170 seconds.
thanks to all for the input!
Wes
---------------Original Message---------------
From: sapwes
Sent: Thursday, May 13, 2010 9:27 AM
Subject: Field-symbols question
> The SAP performance guide indicates that using the assigning command when looping on an internal table improves performance.
> eg LOOP AT ITAB ASSIGNING <WA>
> <WA>-FLAG = 'X'.
> ENDLOOP.
> I have seen this to be true.
> I'm working with a devloper who insists on derefencing the field symbol and using the dereferenced varible
> eg
> LOOP AT ITAB ASSIGNING <WA>
> DerefVal = <WA>
> DerefVal-Flag = 'X'.
> ENDLOOP.
> Other than style issues do you folks have any thoughts how it will affect performance? or any other general thoughts about whether this is a good idea or not?
> Thanks
> Wes
__.____._ De: sapwes via sap-dev [mailto:sap-dev@Groups.ITtoolbox.com]
Enviado el: Jueves, 13 de Mayo de 2010 01:00 p.m.
Para: Horacio Zapettini
Asunto: RE:[sap-dev] Field-symbols question
Posted by sapwes (Jack)
on May 13 at 12:03 PM Mark as helpful
All:
Just checked the code looks like I got it now - the dereferencing is gone (YAY!!). Part of the problem is the developer's unfamiliarity with field symbols.
HZ:
No the perf issue is in the loop.
The original select of of 2mil rows took 22 secs in our QA system. But the loop was taking 13 minutes just to set a eligible flag on the internal table.
We rejiggered the where clause in the select to reduce the rows to 500K, the select is now taking 45 seconds (probaly some indexing issues to resolve). And as well with the field symbol info almost correctly in place, the main loop is now running in 170 seconds.
thanks to all for the input!
Wes
---------------Original Message---------------
From: sapwes
Sent: Thursday, May 13, 2010 9:27 AM
Subject: Field-symbols question
> The SAP performance guide indicates that using the assigning command when looping on an internal table improves performance.
> eg LOOP AT ITAB ASSIGNING <WA>
> <WA>-FLAG = 'X'.
> ENDLOOP.
> I have seen this to be true.
> I'm working with a devloper who insists on derefencing the field symbol and using the dereferenced varible
> eg
> LOOP AT ITAB ASSIGNING <WA>
> DerefVal = <WA>
> DerefVal-Flag = 'X'.
> ENDLOOP.
> Other than style issues do you folks have any thoughts how it will affect performance? or any other general thoughts about whether this is a good idea or not?
> Thanks
> Wes
Copyright © 2010 Toolbox.com and message author.
Toolbox.com 4343 N. Scottsdale Road Suite 280, Scottsdale, AZ 85251
Toolbox.com 4343 N. Scottsdale Road Suite 280, Scottsdale, AZ 85251
horacio zapettiniSAP Development Helper
Posted helpful replies on 5 threads in a group to earn a Bronze Achievement
In the Spotlight
Your SAP Security is at Risk...Learn How to Stay Protected. Read the free white paper from SenSage
View this thread online
Manage group e-mails
Create an FAQ on this topic
Tell us what you think
Unsubscribe from discussion
Manage group e-mails
Create an FAQ on this topic
Tell us what you think
Unsubscribe from discussion
